Making forum skin mobile-friendly

CKH4 · August 22, 2015, 10:49:21 AM

Yes it is, don't let things get too complicated like I do though

.
(I like to use CSS for things that JS would be way better at and my code becomes a nightmare to figure out because I didn't use something that would make it way easier or because I used something improperly)

Also @Streetwalrus this isn't really specific to the mobile theme but you should use border or box shadow for button design since your button images are fairly simple. I had talked to dj about it a while ago but here's a mockup of the idea: http://codepen.io/CKH4/pen/emKMKq

novenary · August 22, 2015, 11:58:32 AM

Sounds good, I'm too lazy to do it now tho.

Dream of Omnimaga · August 22, 2015, 04:04:08 PM

There is a problem with the skin update. When you click Profile or My messages on mobile, one second later it clicks on forum or downloads by itself

(Basically it clicks both buttons within 1 second interval or less)

novenary · August 22, 2015, 04:05:55 PM

That's odd. I have no idea why it would do that.

Dream of Omnimaga · August 22, 2015, 04:10:43 PM

I use latest Chrome on Android 5.1.1 btw and the bug usually happens on the next page after you clicked a navigation link that is still clickable.

Dream of Omnimaga · August 23, 2015, 07:56:00 PM

@Streetwalrus Fatal bug with the new theme update: The login and register buttons can no longer be clicked, so it's no longer possible to login to CW from the site navigation (or entirely on mobile, since the login box on the portal is not available on mobile).

I had to revert the changes by commenting out your CSS, because it prevented people from logging in. This issue can be reproduced in Firefox and Chrome on Windows.

novenary · August 23, 2015, 08:15:42 PM

Oh that, if you'd looked just below you could have fixed it.

Dream of Omnimaga · August 23, 2015, 08:17:50 PM

How?

novenary · August 23, 2015, 08:21:16 PM

You commented out 3 rules. The second one does the link disabling and the third one re-enables some links. Fixed it now.

Dream of Omnimaga · August 24, 2015, 01:28:12 PM

Oh OK. I didn't notice any specific numbers but maybe I didn't check carefully.

Anyway it works now it seems.

The thing, though, is are the links CSS hard-coded or something? Because if we ever decide to change the navigation around and insert extra stuff between Downloads and About, for example, then wouldn't links to the right become out of sync with the CSS?

novenary · August 24, 2015, 01:49:22 PM

I made it so that links are disabled by default, and they're re-enabled with a per-id whitelist.

Dream of Omnimaga · August 24, 2015, 03:18:18 PM

Ah I see. That was my concern actually. If we shift them around we need to not forget to change the whitelist, to not lock people out without noticing.

novenary · August 24, 2015, 03:54:37 PM

The id is by name. Check the code out.

You just need to not forget adding stuff to the whitelist or you'll wonder why it doesn't work.

Dream of Omnimaga · August 24, 2015, 05:38:49 PM

Ah I didn't know that each navigation options had individual names.

CKH4 · August 24, 2015, 09:53:46 PM

You could do a nextsibling subitems (or whatever) JS selector. That may make things more automated while still allowing the whitelist.