CodeWalrus

DJ, could you make notifs when people edit posts on their thread?
Ex. Edited Walrified topic by xMarminq_ on Change The WalrusIRC http://codewalr.us/1710/47555
I think this could help me and probably other people too.
If there are multiple edit in a row, the most recent will cancel out the others, but not the original post tag. 

Plus sometimes I cannot click people's (Are you guys people?  ;)) profiles tags when they chat.

Yes I believe it would be nice if edits showed up.

The reason you can't click on some peoples names is because they are connected through IRC not walrusIRC.

Quote from: xMarminq_ on November 13, 2016, 12:36:26 AM
DJ

Not him in charge of that. More like me or @Streetwalrus, who actually knows how to do that. And I'm not even sure how to do that. If I found out, then yeah, I could. Maybe. My main concern is edit spamming, and I'm definitely not sure what you say to do for this problem is even doable.

Quote from: Juju on November 13, 2016, 01:57:58 AM

Quote from: xMarminq_ on November 13, 2016, 12:36:26 AM
DJ

Not him in charge of that. More like me or @Streetwalrus, who actually knows how to do that. And I'm not even sure how to do that. If I found out, then yeah, I could. Maybe. My main concern is edit spamming, and I'm definitely not sure what you say to do for this problem is even doable.

Only display a message if the post or last edit was >10 minutes ago.

That could work, actually.

I agree :3=

Idk how omni does it, but they use the same criteria as smf making an edited post unread.

Quote from: Streetwalrus on November 13, 2016, 11:12:15 AM
Idk how omni does it, but they use the same criteria as smf making an edited post unread.

Like this: https://github.com/Sorunome/OmnomIRC/blob/master/forum_mods/smf/forum/install.xml#L60-L87

Edits would be nice, as long as there is spam protection for when we have to edit 5 times in a row

Kinda what I said in the first post.
(Forth Line)

Can't we just add a checkbox "Show this edit in IRC"? :)

That would be hard to integrate without significant SMF knowledge.

So what's your verdict?

Maybe it should just say

"Walrified edit by xMarminq_"

instead of (for example)

"Walrified edit by xMarminq_ on Re: Change The WalrusIRC http://codewalr.us/1710/47581"

Still needs topic though

I don't think so

What's the point of alerting people that an edit has been made if there's no way of telling where?

Only if it is the most recent. I want this to help reduce double posting.

Quote from: c4ooo on November 14, 2016, 02:04:43 AM
What's the point of alerting people that an edit has been made if there's no way of telling where?

if someone's following you then they will be able to find the edit

it reduces information flooding in the chat box with this method.

Omnimaga and cemetech have this and there's no information flood. Theres absolutely no point in "flooding" the chat (in quotes because one line of text isn't flooding) without telling where the change was made.

but there's something secretive and nice about making edits at the minute

Well, editing posts has different reasons. Typo, wrong information, or just for fun. So it's better if there's a check box to choose whether you would like to show this. (Maybe a hidden tag in plain text could be handy and useful?)

Not at all dj, sorunome pointed us to the right logic to determine whether to notify of an edit. Even the check box would be easy to do.

Streetwalrus yeah I meant if we decided to do it on our own without anyone's help. :P

As for what people said after my post, specifically @c4ooo , specifying what was changed in the post would not be feasible, because what if a 50000 character block of text was added/replaced in the post during the edit? Would the bot spams IRC with that entire change?

Also this would require us to start storing past versions of forum posts. This is feasible for the time being (via SMF mods that already exists for 2.0, but not for 2.1 yet), but we only have 30 GB of disk space on the server, which will fills up incredibly fast if we start storing every single version of each post.

Also I am against notifying of edits if it's done on the last post of a thread and that it has been over 24 hours since the last reply. We should still encourage topic bumping if it has already been 24 hours since the last post.


Even for older posts I would prefer if it was a checkbox option, for privacy reasons.

Quote from: DJ Omnimaga on November 14, 2016, 08:29:40 AM
Also this would require us to start storing past versions of forum posts. This is feasible for the time being (via SMF mods that already exists for 2.0, but not for 2.1 yet), but we only have 30 GB of disk space on the server, which will fills up incredibly fast if we start storing every single version of each post.

No. In that case we would still link to the most recent version of that post. We don't need to put what changed on IRC either. It would say something along the lines of, Walrified edit by ThatGuy on ThisPost LinkOfPostHere.

What c4ooo wants however is that what in the post has changed gets displayed on IRC by the bot. Or at least, that's what I am gathering from his post. IN any case, such idea would not be implemented.

Quote from: DJ Omnimaga on November 14, 2016, 08:29:40 AM
As for what people said after my post, specifically @c4ooo , specifying what was changed in the post would not be feasible, because what if a 50000 character block of text was added/replaced in the post during the edit? Would the bot spams IRC with that entire change?

As far as I understood, kotu was suggesting was only saying a change has been made, and not posting the link to the post. I never said the *change* should be posted in IRC ;)

Oh ok, but then not posting the link is counterproductive if it has been a long while since the last reply was made. People might be curious and want to read the post without having to search Google for the URL.

profile info -> show posts ??

Then the user who is on IRC has to type the forum URL inside his browser bar manually, then find the user profile, then click show posts, then find the post, which could be an old post he edited and is on page 40-50 or so.

If we are gonna make it such hassle to see someone's post edits from IRC, then we might as well not implement them at all.

Omnimaga and Cemetech edits works fine other than the privacy issue for people who don't want a specific edit to appear publicly (eg an old personal-related post or unnecessary rehashing of old drama). I was only against that feature at first due to how spammy it can get when there is a 100+ posts day, but it's not like those happen often.

Quote from: DJ Omnimaga on November 14, 2016, 11:57:40 PM
Then the user who is on IRC has to type the forum URL inside his browser bar manually, then find the user profile, then click show posts, then find the post, which could be an old post he edited and is on page 40-50 or so.

If we are gonna make it such hassle to see someone's post edits from IRC, then we might as well not implement them at all.

Omnimaga and Cemetech edits works fine other than the privacy issue for people who don't want a specific edit to appear publicly (eg an old personal-related post or unnecessary rehashing of old drama). I was only against that feature at first due to how spammy it can get when there is a 100+ posts day, but it's not like those happen often.

^Basicly this.
About the privacy issue, a "dont notify of edit" button could work, but isn't necessary.

Yeah the thing @c4ooo is that for example, my Omnimaga/SAX goodbye post contains some severely outdated info and the topic is still among the top pages of the misc section, meaning it could mislead people. However, I don't want people to go apec and think I am back (which happened a few times when I logged in before) and give people false hope, or to think it's a 2016 post because they didn't read the date and stuff. That and sometimes it's nice to be able to edit without everyone jumping at you thinking you're available when in fact you're on your 15 minutes break at work.